[tor-bugs] #5114 [Tor Client]: Environ not available on all versions of OS X, segfaults tor with obfsproxy

[Tor Bug Tracker & Wiki]

#5114: Environ not available on all versions of OS X, segfaults tor with obfsproxy
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  major       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 I really don't like "HAVE_CRT_EXTERNS_H" as a test here.  We want to know
 about _NSGetEnviron, not about the header that it is declared in.

 How do you like the "bug5114" branch in my public repository?  It tests
 for _NSGetEnviron, and also refactors the environ/_NSGetEnviron decision
 into compat.c where it arguably belongs.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5114#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online