[tor-bugs] #5084 [Tor Bridge]: pt_prepare_proxy_list_for_config_read: Assertion unconfigured_proxies_n == 0 failed

[Tor Bug Tracker & Wiki]

#5084: pt_prepare_proxy_list_for_config_read: Assertion unconfigured_proxies_n ==
0 failed
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  major       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 Vidalia is doing two setconfs in quick succession.

 The first one causes pt_kickstart_proxy() to find that mp->got_hup and
 mp->marked_for_removal are true, so it increments unconfigured_proxies_n
 to 1. The second one finds unconfigured_proxies_n to still be 1, yet the
 mp in the list has conf_state PT_PROTO_COMPLETED so it doesn't call
 managed_proxy_destroy() on it, and then triggers the assert since it
 finished going through the list yet unconfigured_proxies_n is still 1.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5084#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online