[tor-bugs] #5074 [Obfsproxy]: obfsproxy assertion failure src/container.c:66: size <= MAX_CAPACITY

[Tor Bug Tracker & Wiki]

#5074: obfsproxy assertion failure src/container.c:66: size <= MAX_CAPACITY
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:  asn
     Type:  defect     |         Status:  new
 Priority:  normal     |      Milestone:     
Component:  Obfsproxy  |        Version:     
 Keywords:             |         Parent:     
   Points:             |   Actualpoints:     
-----------------------+----------------------------------------------------

Comment(by asn):

 We are using two smartlists in the networking code. A smartlist for
 listeners, which has a static size till the halt of obfsproxy, and a
 smartlist for connections.

 <captain obvious>
 My guess would be that we do an extra `smartlist_remove()` in the
 connection smartlist, the smartlist counter becomes negative, and then we
 try to add another connection and we notice it in
 `smartlist_ensure_capacity()`. The circuit concept makes connection
 removal kinda groovy, and we should look at how `conn_free()` does it
 carefully.
 </captain obvious>

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5074#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online