[tor-bugs] #7708 [Tor]: connection_handle_write_impl mishandles TOR_TLS_WANT_WRITE

[Tor Bug Tracker & Wiki]

#7708: connection_handle_write_impl mishandles TOR_TLS_WANT_WRITE
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  major      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor        |        Version:                    
 Keywords:  tor-relay  |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
Changes (by nickm):

  * status:  new => needs_review


Comment:

 Whoa, I think this was introduced back in ef2409e4e.

 I've done a shorter fix as branch "bug7708_023" ; I think it should get
 tested in 0.2.4 and backported to 0.2.3 if it seems okay in 0.2.4 after a
 while.

 I'd also like to refactor the fetch_from_buf_tls and read_to_buf_tls
 functions at long last: Their interface is begging for this kind of
 breakage.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7708#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online