[tor-bugs] #7664 [Ooni]: ooniprobe decks do not appear to work

[Tor Bug Tracker & Wiki]

#7664: ooniprobe decks do not appear to work
------------------------+---------------------------------------------------
    Reporter:  ioerror  |       Owner:  hellais
        Type:  defect   |      Status:  closed 
    Priority:  normal   |   Milestone:         
   Component:  Ooni     |     Version:         
  Resolution:  fixed    |    Keywords:         
      Parent:           |      Points:         
Actualpoints:           |  
------------------------+---------------------------------------------------

Old description:

> I've been trying to run various decks - only to have just a few yamloo
> files - generally in the form of foo.yamloo and foo.yamloo.old - even the
> before_i_commit.deck is outputting just http_host.yamloo.yamloo and
> http_host.yamloo.yamloo.old - the latter has dns tests in it. Something
> is totally wacked.

New description:

 I've been trying to run various decks - only to have just a few yamloo
 files - generally in the form of foo.yamloo and foo.yamloo.old - even the
 before_i_commit.deck is outputting just http_host.yamloo.yamloo and
 http_host.yamloo.yamloo.old - the latter has dns tests in it. Something is
 totally wacked.

--

Comment(by hellais):

 Replying to [comment:6 ioerror]:
 > Ok - it appears that the git tip of master works for decks again. I
 would say that this bug is likely to come back again - it will be some
 other thing that shouldn't be called. So how about we turn this bug into a
 bug where we document those things or implement helper classes, so people
 do not even call potentially dangerous methods or functions?

 The *only* two function that should not be called are reactor.stop and
 reactor.start, and I though it was quite obvious that this would have been
 the case. Since apparently it is not so obvious I added it to the tutorial
 on writing tests: https://gitweb.torproject.org/ooni-
 probe.git/commit/53ed7f69ff809e20eeaaaa4e3797e1da155de6a2

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7664#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online