[tor-bugs] #4019 [Tor Client]: Tor warns about public SocksPort addresses twice on startup

[Tor Bug Tracker & Wiki]

#4019: Tor warns about public SocksPort addresses twice on startup
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:  tomfitzhenry      
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by tomfitzhenry):

  * status:  assigned => needs_review
 * cc: trac-tor@… (added)


Comment:

 There are a few ways to fix this, including:
     1. When calling parse_ports, toggle CL_PORT_WARN_NONLOCAL on each type
 of port (SocksPort, DNSPort, etc.) based on whether validate_only is set.
 validate_only is set when validating the config file, but not when reading
 the config file to decide what to listen on.
     2. As above, but in another method in the call stack.
     3. Don't print warnings. Rather, pass them back up and decide whether
 to output based on whether we're validating the config file or opening
 listeners.
     4. Rewrite to only read the config once (scary! Not worth it for this
 minor issue.)

 I went for 1, because it seemed like the most sensible place to put it in
 the call stack. 3 and 4 are non-trivial changes, that this small issue
 doesn't justify.

 Feedback welcome!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4019#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online