[tor-bugs] #5647 [Tor Hidden Services]: rend_parse_client_keys() prints stack in logs if base64_decode fails

[Tor Bug Tracker & Wiki]

#5647: rend_parse_client_keys() prints stack in logs if base64_decode fails
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:                    
     Type:  defect               |         Status:  needs_review      
 Priority:  normal               |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by asn):

 It seems to me that `base64_decode()` simply trusts `srclen` and doesn't
 assume that the input is a NUL-terminated string. I think that NUL will
 simply reach
 {{{
     unsigned char c = (unsigned char) *src;
     uint8_t v = base64_decode_table[c];
 }}}
 return `X` and `base64_decode()` will fail. I could be wrong though.

 In any case, `bug5647_cleanup` looks good to me.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5647#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online