[tor-bugs] #5572 [Tor Relay]: Tor fails to store dynamic DH modulus on first start

[Tor Bug Tracker & Wiki]

#5572: Tor fails to store dynamic DH modulus on first start
-----------------------+----------------------------------------------------
 Reporter:  koolfy     |          Owner:                     
     Type:  defect     |         Status:  new                
 Priority:  normal     |      Milestone:                     
Component:  Tor Relay  |        Version:  Tor: 0.2.3.13-alpha
 Keywords:  datadir    |         Parent:                     
   Points:             |   Actualpoints:                     
-----------------------+----------------------------------------------------
 when first starting tor as a relay, notice logs complain about not being
 able to open the file it wants to write dynamic DH modulus to for writing.


 [WARN] Couldn't open "/var/lib/tor/keys/dynamic_dh_params"
 [NOTICE] Failed while storing dynamic DH modulus. Make sure your data
 directory is sane.

 It would appear that /var/lib/tor/keys is created *after* tor tries to
 open dynamic_dh_params, thus the first time tor is started as a relay, it
 generates DH modulus and fails to save them.
 The second time, however, as /var/lib/tor/keys has been created, tor
 generates other DH modulus, and is then able to save those.

 I guess it shouldn't be hard to fix once the code responsible for that
 sequence is located and put back in the right order so that keys is
 created before trying to save any DH Modulus.


 tor version tested was from the current latest git for 0.2.3.13-alpha
 (commit b8e582255e8ee920904c71ed9d4ff3927f22757a)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5572>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online