[tor-bugs] #4085 [Tor Relay]: We don't count accounting bytes when time moves backward?

[Tor Bug Tracker & Wiki]

#4085: We don't count accounting bytes when time moves backward?
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  minor      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
 In main.c's second_elapsed_callback() we do:

 {{{
   if (accounting_is_enabled(options) && seconds_elapsed >= 0)
     accounting_add_bytes(bytes_read, bytes_written, seconds_elapsed);
 }}}

 So that means if our clock goes backwards, we don't count whatever bytes
 we spent towards whether we should hibernate.

 Is that actually wise? Does this situation happen often enough to matter?
 This bandwidth accounting stuff is messy.

 (Noticed while reading patch for #3630)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4085>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online