[tor-bugs] #4018 [Tor Client]: warn_nonlocal_client_ports should use tor_addr_is_internal, not _is_loopback

[Tor Bug Tracker & Wiki]

#4018: warn_nonlocal_client_ports should use tor_addr_is_internal, not
_is_loopback
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:  rransom           
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:  easy        |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 I like it, but I don't want to remove the warning for non-loopback
 addresses entirely.  If the address is internal but not noopback, then can
 we say something like, "You specified an internal address for FooPort.
 Other people on your local network can find your Tor program and use it as
 a proxy."

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4018#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online