[tor-bugs] #4349 [Tor Relay]: netinfo cells declare canonical address for the remote OR, not actual address of the conn

[Tor Bug Tracker & Wiki]

#4349: netinfo cells declare canonical address for the remote OR, not actual
address of the conn
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  normal     |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
 In connection_or_send_netinfo() we write
 {{{
   /* Their address. */
   out = cell.payload + 4;
   len = append_address_to_payload(out, &conn->_base.addr);
 }}}

 But the goal here is to say the actual address the conn came from/to, yes?
 If so, shouldn't it be conn->real_addr?

 Reported by "troll_un".

 Targeting this one on 0.2.2 since when we eventually start using the
 contents of netinfo cells, we'll wish everybody had the fix.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4349>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online