[tor-bugs] #4296 [Tor Client]: Trivial issues in tor_spawn_background()/tor_check_port_forwarding()

[Tor Bug Tracker & Wiki]

#4296: Trivial issues in tor_spawn_background()/tor_check_port_forwarding()
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:              
     Type:  defect      |         Status:  needs_review
 Priority:  normal      |      Milestone:              
Component:  Tor Client  |        Version:              
 Keywords:              |         Parent:              
   Points:              |   Actualpoints:              
------------------------+---------------------------------------------------

Comment(by nickm):

 95df581c054595 looks okay, but I don't know about 859b279a5cf25.  In
 859b279a5cf25, it looks like we are only calling CloseHandle on that one
 path through log_from_handle, but we aren't closing it on the other paths.
 I would expect that either all paths should close it, or none should, or
 that the documentation would explain why that sometimes-close behavior was
 reasonable.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4296#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online