[tor-bugs] #4587 [Tor Client]: Bugs in tor_tls_got_client_hello()

[Tor Bug Tracker & Wiki]

#4587: Bugs in tor_tls_got_client_hello()
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by troll_un):

 Replying to [comment:12 asn]:
 > Hm, looking at #4594. Do you think we can get the correct count of
 handshakes by only counting them in `SSL3_ST_SR_CLNT_HELLO_A`?

 No you can't distinguish second hello during handshake and hello for reneg
 req. ssl3_get_client_hello() could return negative as reason non blocking
 io, so state during next call of ssl3_accept() can be as well as
 SSL3_ST_SR_CLNT_HELLO_B or SSL3_ST_SR_CLNT_HELLO_C. And
 SSL3_ST_SR_CLNT_HELLO_C is state that used if second hello during hanshake
 happened.

 You need to wait for _A or _B or _C, and count (all) hellos. For
 distinguish reneg req only you need another logic (not depends of state
 during callbacks).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4587#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online