[tor-bugs] #4312 [Tor Relay]: Rate limit renegotiations

[Tor Bug Tracker & Wiki]

#4312: Rate limit renegotiations
-----------------------+----------------------------------------------------
 Reporter:  asn        |          Owner:              
     Type:  defect     |         Status:  needs_review
 Priority:  normal     |      Milestone:              
Component:  Tor Relay  |        Version:              
 Keywords:             |         Parent:              
   Points:             |   Actualpoints:              
-----------------------+----------------------------------------------------

Comment(by asn):

 Check out branch `bug4312`.

 I'm still somewhat worrying about the callback trigger timing. For
 example, if someone sends excess renegotiation requests *and* manages to
 mark the connection for close before the next event loop, after the
 callback is triggered we will have a double mark-for-close. Or, if the
 excess-reneg. callback is called *after* second_elapsed_callback() and
 close_closeable_connections() is called, then the callback pointer will be
 NULLed if the connection was marked-for-close.

 (btw, seems like the memleak of comment:13 was not caused by this code; my
 branch parent was kinda old and it was caused by #4252.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4312#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online