[tor-bugs] #4453 [Torbutton]: Torbutton always reset SOCKS port to 9050

[Tor Bug Tracker & Wiki]

#4453: Torbutton always reset SOCKS port to 9050
-----------------------+----------------------------------------------------
 Reporter:  lunar      |          Owner:  lunar           
     Type:  defect     |         Status:  assigned        
 Priority:  normal     |      Milestone:                  
Component:  Torbutton  |        Version:  Torbutton: 1.4.4
 Keywords:             |         Parent:                  
   Points:             |   Actualpoints:                  
-----------------------+----------------------------------------------------
Changes (by mikeperry):

  * owner:  mikeperry => lunar
  * status:  needs_review => assigned


Comment:

 Did you test this in both TBB and Iceweasel? I suspect if you tested it in
 TBB, it will break after you open a 2nd new window, because it will reset
 the SOCKS port to 9050.

 The problem is that the TOR_SOCKS_PORT is not used in
 torbutton_init_prefs().. torbutton_init_prefs() is called on every new
 window (yes, this is somewhat dumb, but it is a relic of old code).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4453#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online