[tor-bugs] #4367 [Tor Relay]: command_process_auth_challenge_cell() mishandles lack of expected auth type

[Tor Bug Tracker & Wiki]

#4367: command_process_auth_challenge_cell() mishandles lack of expected auth type
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by arma):

 Replying to [ticket:4367 arma]:
 > I think we can fix just by initting use_type to 0.

 Unless we want to support 0 as a valid auth type in the future, in which
 case we should leave use_type initialized to -1 and change the check to
 "if use_type >= 0 &&".

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4367#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online