[tor-bugs] #3289 [Tor Hidden Services]: Tor does not complain if the user specifies two HSes with the same HiddenServiceDir

[Tor Bug Tracker & Wiki]

#3289: Tor does not complain if the user specifies two HSes with the same
HiddenServiceDir
---------------------------------+------------------------------------------
 Reporter:  rransom              |          Owner:  rransom           
     Type:  defect               |         Status:  needs_review      
 Priority:  normal               |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by arma):

 I don't object to this general direction. I think rransom's idea of doing
 an exact cmp is better, if we're not doing stat or lock files.

 That said,
 {{{
     SMARTLIST_FOREACH(rend_service_list, rend_service_t*, ptr,
                       dupe = !strcmp(ptr->directory, service->directory));
     if (dupe) {
 }}}
 is only going to check if the last entry in rend_service_list matches,
 right?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3289#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online