[tor-bugs] #3263 [Tor Relay]: only publish new descriptor if onion key has changed

[Tor Bug Tracker & Wiki]

#3263: only publish new descriptor if onion key has changed
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
Changes (by arma):

  * status:  new => needs_review


Comment:

 See my bug3263 branch.

 In particular, it needs review of:

 A) Should I be doing the key comparison inside the mutex? I think no.

 B) Are there other things that init_keys() does that *do* want a new
 descriptor to be uploaded? I worry we're swinging the pendulum the other
 way and uncovering bugs that were masked by the "always republish" bug.

 Issue "B" is why I've targeted this bugfix on 0.2.3.x.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3263#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online