[tor-bugs] #3049 [Tor Client]: Allow a Tor process to be ‘owned’ by a controller process
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Mon May 16 00:38:30 UTC 2011
#3049: Allow a Tor process to be ‘owned’ by a controller process
-------------------------+--------------------------------------------------
Reporter: rransom | Owner: rransom
Type: enhancement | Status: needs_review
Priority: major | Milestone: Tor: 0.2.2.x-final
Component: Tor Client | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by nickm):
Quick review of stuff through the current head ( f0c70fb52f44 ) :
* Is there a system where we don't expect owning_controller_process_spec
to be an integer of some type?
* Instead of having the functions take an event_base, you can just have
them call tor_libevent_get_base.
* For the timer, I'd suggest looking at periodic_timer_new; it's a little
more accurate, and IMO makes our intent clearer.
* In monitor_owning_controller_process, if we're going to make a failure
to allocate owning_controller_process_monitor be a recoverable error, we
should make sure that it frees and clears owning_controller_process_spec
so that the two are consistent again. On the other hand, if we ''don't''
plan to make it a recoverable error, then the log message should be
log_err.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3049#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list