[tor-bugs] #2688 [BridgeDB]: BridgeDB re-assigns unallocated bridges from/to file buckets without need

[Tor Bug Tracker & Wiki]

#2688: BridgeDB re-assigns unallocated bridges from/to file buckets without need
----------------------+-----------------------------------------------------
 Reporter:  karsten   |          Owner:  kaner       
     Type:  defect    |         Status:  needs_review
 Priority:  major     |      Milestone:              
Component:  BridgeDB  |        Version:              
 Keywords:            |         Parent:              
   Points:            |   Actualpoints:              
----------------------+-----------------------------------------------------
Changes (by kaner):

  * status:  assigned => needs_review


Comment:

 Replying to [comment:5 karsten]:
 >  - The code changes look good, but I'm having a hard time finding what
 precise change fixed the bug.  Does it have to do with the pseudo
 distributor prefix?  Can you explain?

 Yes, thats correct. The pseudo distributor prefix was missing in the list
 of buckets.

 >  - Why did you change the list type bucketList to the dictionary type
 buckets?  If this change is not part of the bugfix, please take it out of
 this commit and make a separate commit for refactoring stuff.

 I thought there'd be a search performance optimization looking up a
 specific bucket in the list. Turns out it isn't worth it. Especially with
 the ugliefication that incrementBucket() introduces. Dismissed this
 change.

 >  - See also the changes in branch bug2866 in my public repository.  Note
 that I didn't test these changes yet.

 Cherry-picked those.

 See branch bug2688_rebased for a cleaned up version.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2688#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online