[tor-bugs] #2688 [BridgeDB]: BridgeDB re-assigns unallocated bridges from/to file buckets without need

[Tor Bug Tracker & Wiki]

#2688: BridgeDB re-assigns unallocated bridges from/to file buckets without need
----------------------+-----------------------------------------------------
 Reporter:  karsten   |          Owner:  kaner   
     Type:  defect    |         Status:  assigned
 Priority:  major     |      Milestone:          
Component:  BridgeDB  |        Version:          
 Keywords:            |         Parent:          
   Points:            |   Actualpoints:          
----------------------+-----------------------------------------------------
Changes (by karsten):

  * status:  needs_review => assigned


Comment:

 - The code changes look good, but I'm having a hard time finding what
 precise change fixed the bug.  Does it have to do with the pseudo
 distributor prefix?  Can you explain?

  - Please pick a better commit message than "Fix #2688".  Something self-
 contained would be good.  The message should explain what the bug was and
 what the fix is.

  - Why did you change the list type bucketList to the dictionary type
 buckets?  If this change is not part of the bugfix, please take it out of
 this commit and make a separate commit for refactoring stuff.

  - What's the purpose of adding incrementBucket()?  Why is this a method
 of BucketManager and not BucketData?  Also, the failure mode of not doing
 anything if the bucket name cannot be found seems unsafe to me; is this
 intended?  Again, if this is a refactoring thing only, please take it out
 of this commit.

  - See also the changes in branch bug2866 in my public repository.  Note
 that I didn't test these changes yet.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2688#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online