[tor-bugs] #1090 [Tor Client]: Warning about using an excluded node for exit

[Tor Bug Tracker & Wiki]

#1090: Warning about using an excluded node for exit
---------------------------+------------------------------------------------
    Reporter:  Sebastian   |       Owner:  nickm             
        Type:  defect      |      Status:  needs_review      
    Priority:  major       |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Client  |     Version:  0.2.1.19          
  Resolution:  None        |    Keywords:                    
      Parent:              |      Points:                    
Actualpoints:              |  
---------------------------+------------------------------------------------

Comment(by nickm):

 Replying to [comment:43 nickm]:
 > So, there are 8 XXX022-1090 issues as of the head of my XXX1090-branch
 today:

 I guess I should say what I think we should do about these too.

 >  * In circuitbuild.c, choose_good_exit_server_general(): Currently,
 people who set "ExitNodes" do not get restrictions based on
 router_is_unreliable.  This creates a partitioning opportunity.

 I think the answer here is just to take out the "if you have ExitNodes
 set, then ignore router_is_unreliable" logic.  We already have code later
 in the function that retries choose_good_exit_server_general with
 need_uptime and need_capacity set to 0 if at least one of them was set and
 no nodes were found.

 This way, if the only exits we could consider are unreliable, we use an
 unreliable exit, but otherwise we use a reliable one.

 I've checked in a patch for this.

 >  * In circuitbuild.c, warn_if_last_router_excluded(): The "using anyway"
 warning fires too often, confuses people, and generally freaks everybody
 out.

 The purpose of this warning is twofold:
   * To try to detect bugs.  (This bug, to be specific)
   * To let people know that if they have set StrictNodes 0, they will
 sometimes get Excluded nodes used.

 These two kinds of issues want really different log messages.

 -- gotta go for now; more on this later.

 Also, I added 2 more XXX022-1090 items related to changing or
 reclassifying circuits.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1090#comment:45>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online