[tor-bugs] #2757 [Tor Client]: Bug: Duplicate call to connection_mark_for_close

[Tor Bug Tracker & Wiki]

#2757: Bug: Duplicate call to connection_mark_for_close
------------------------+---------------------------------------------------
 Reporter:  tornewbie   |          Owner:  nickm   
     Type:  defect      |         Status:  assigned
 Priority:  normal      |      Milestone:          
Component:  Tor Client  |        Version:          
 Keywords:              |         Parent:          
   Points:              |   Actualpoints:          
------------------------+---------------------------------------------------
Changes (by nickm):

  * owner:  => nickm
  * status:  new => assigned


Comment:

 oho, except that there was a bug in the #2279 fix, it seems:

 {{{
   if (connection_init_accepted_conn(newconn, conn->type) < 0) {
     if (! conn->marked_for_close)
       connection_mark_for_close(newconn);
     return 0;
   }
 }}}

 One of these conns is not like the others...

 (writing patch now)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2757#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online