[tor-bugs] #2732 [Tor Hidden Services]: Simplify hid_serv_responsible_for_desc_id

[Tor Bug Tracker & Wiki]

#2732: Simplify hid_serv_responsible_for_desc_id
---------------------------------+------------------------------------------
 Reporter:  rransom              |          Owner:  rransom           
     Type:  defect               |         Status:  needs_review      
 Priority:  major                |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by nickm):

 I'm not sure this is the behavior we want; I think the old thing might be
 deliberate but broken.

 I think that the intention might have been for us to store the descriptor
 not only if we are listed as an HSDir at the right place in the consensus,
 but also if we are not an HSDir but we *are* listed in the right place in
 the consensus.  This is broken since the check for
 hid_serv_acting_as_directory() depends on the HSDir flag.

 So I'd like to make sure that the intent *isn't* for non-HSDir routers to
 store descriptors anyway before we merge this.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2732#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online