[tor-bugs] #2612 [Vidalia]: Add support for Win2k
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Thu Mar 10 12:36:53 UTC 2011
#2612: Add support for Win2k
-------------------------+--------------------------------------------------
Reporter: chiiph | Owner: chiiph
Type: enhancement | Status: needs_review
Priority: normal | Milestone:
Component: Vidalia | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by chiiph):
Replying to [comment:4 edmanm]:
> What function in what header?
getnameinfo (and may be others that got inlined when including the header
file).
> And ship what header with what inline? If you're talking about shipping
`wspiapi.h` from the Windows SDK in Vidalia's source tree, I think that's
a non-starter. The EULA you click through when installing the SDK sure
doesn't seem to permit that.
No, the header file will just be compiled in as a dependency, not shipped
with Vidalia's source tree.
> If there's something in a miniupnpc file that needs to be tweaked to
respect the `-DNO_GETADDRINFO` flag or avoid some other function that
doesn't exist on Win2K, why not just do that?
The macro is GETHOSTBYNAME, but there are a couple of calls that don't use
that (and it isn't used in the getnameinfo call either). The code in
miniupnpc is really ugly, and the developer already told me: "that needs
to be fixed... I think you can make it :)" (literaly). So, I'm not a real
fun of hacking the lib to make this work.
>
> I agree that most Windows users don't build Vidalia from source, but why
should we make life harder for those poor suckers that do? Vidalia is
still relatively easy to build for Windows users and I'd sure like to keep
it that way if possible.
I can make a tutorial on how to build Vidalia on Windows, or just add a
those steps on a README, and refer the two or three users to that when
they complain.
Another possibility is to use a define (disabled by default) "-DWIN2K" or
something, that Erinn can use when building the bundles, and the regular
user that wants to build it in Windows XP or 7 won't notice a thing.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2612#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list