[tor-bugs] #2652 [Tor Relay]: Clean up use of SSL_*_app_data functions

[Tor Bug Tracker & Wiki]

#2652: Clean up use of SSL_*_app_data functions
-----------------------+----------------------------------------------------
 Reporter:  rransom    |          Owner:  rransom           
     Type:  defect     |         Status:  needs_review      
 Priority:  major      |      Milestone:  Tor: 0.2.3.1-alpha
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
Changes (by rransom):

  * status:  new => needs_review


Comment:

 See
 [http://repo.or.cz/w/tor/rransom.git/shortlog/refs/heads/use_ex_data_directly
 use_ex_data_directly] ( !ssh://mob@repo.or.cz/srv/git/tor/rransom.git
 use_ex_data_directly ) for cleanup patches.

 I tried to understand the inner workings of the `SSL_*_ex_data` functions
 and failed.  I wrote the patches in use_ex_data_directly based on the
 information in the relevant OpenSSL man pages.  I do not trust the
 `ex_data` functions; I only wrote these patches because nickm and ioerror
 are determined to not switch back to using the hash table removed by
 commit 49de5431d53b, and I distrust the `app_data` macros even more than I
 distrust the `ex_data` functions.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2652#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online