[tor-bugs] #3428 [Tor Client]: Control port may emit log messages in the middle of another event/reply

[Tor Bug Tracker & Wiki]

#3428: Control port may emit log messages in the middle of another event/reply
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:  rransom         
     Type:  defect      |         Status:  needs_review    
 Priority:  normal      |      Milestone:  Tor: unspecified
Component:  Tor Client  |        Version:                  
 Keywords:              |         Parent:                  
   Points:              |   Actualpoints:                  
------------------------+---------------------------------------------------
Changes (by rransom):

  * status:  new => needs_review
  * milestone:  Tor: 0.2.3.x-final => Tor: unspecified


Comment:

 See
 [https://gitweb.torproject.org/rransom/tor.git/shortlog/refs/heads/bug3428b
 bug3428b] ( `git://git.torproject.org/rransom/tor.git bug3428b` ) for a
 patch for master to make `connection_printf_to_buf` exit (rather than
 warn) if `tor_vasprintf` fails.  I expect that there are other cases where
 the control-port code can emit a log message in the middle of another
 event or reply, so this patch doesn't resolve the ticket.

 See
 [https://gitweb.torproject.org/rransom/tor.git/shortlog/refs/heads/bug3428
 bug3428] ( `git://git.torproject.org/rransom/tor.git bug3428` ) for an
 implementation of a linked-list-based queue that should be useful when we
 do really fix this bug.  (It needs more unit tests first.)

 I don't know what to put into the queue -- `buf_t`s? `evbuffer`s?
 `smartlist_t`s of `sized_chunk_t`s?  Whatever we use needs to have a
 `printf_to_X` function and a `copy_X_to_bufferevent` function, and be at
 least tolerably lightweight.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3428#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online