[tor-bugs] #3409 [Torctl]: TorCtl connect method inflexible

[Tor Bug Tracker & Wiki]

#3409: TorCtl connect method inflexible
-------------------------+--------------------------------------------------
 Reporter:  atagar       |          Owner:     
     Type:  enhancement  |         Status:  new
 Priority:  normal       |      Milestone:     
Component:  Torctl       |        Version:     
 Keywords:               |         Parent:     
   Points:               |   Actualpoints:     
-------------------------+--------------------------------------------------
 The connect method is a nice helper for cli initiation, but lacks
 sufficient call visibility to help in more general use cases. In
 particular it...
 - sends feedback to stdout
 - prompts for the controller password on stdin
 - suppresses exceptions

 To get around this I'm adding a more generic 'connectionComp' that does
 the icky bits of the connection negotiation I was trying to hide while
 still giving the caller what it needs to handle the connection process
 however it'd like.

 Tested by exercising the connect functionality with cookies, password, and
 connection components to handle my TBB cookie auth renegotiation fix.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3409>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online