[tor-bugs] #3407 [Tor Client]: connection_printf_to_buf is crazypants bizarre!

Thu Jun 16 04:15:59 UTC 2011

#3407: connection_printf_to_buf is crazypants bizarre!
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:  rransom           
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 `connection_printf_to_buf`'s callers expect it to emit a CRLF iff the
 format string ends with CRLF; it actually emits a CRLF iff (a) the format
 string ends with CRLF or (b) the resulting string is over 1023 characters
 long or (c) the format string does not end with CRLF ''and'' the resulting
 string is 1021 characters long or longer.  (I may be wrong about the exact
 string lengths there.)

 `connection_printf_to_buf` should be made less flaky.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3407>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online