[tor-bugs] #3627 [Tor Client]: Split edge_connection_t into edge_connection_t and entry_connection_t

[Tor Bug Tracker & Wiki]

#3627: Split edge_connection_t into edge_connection_t and entry_connection_t
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 >the second check is redundant

 Noted; will fix.

 > Do you plan to make an exit_connection_t? It confuses me that
 edge_connection_new() now asserts that type can only be CONN_TYPE_EXIT.

 Only if there were a significant number of fields to move into it.

 > Is it time to s/CONN_TYPE_AP/CONN_TYPE_ENTRY/g yet?

 Perhaps.

 I'm also interested in what you think of this idea in general.  Is it
 worth doing IYO?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3627#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online