[tor-bugs] #3569 [Tor Client]: Refactor socks parsing

[Tor Bug Tracker & Wiki]

#3569: Refactor socks parsing
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 The function parse_socks and its interactions wit the functions that call
 it have grown nigh-unmaintainably complex.  Let's replace it with a
 simple, more linear function.  Key points:

   * State should be kept explicitly.  Let's forget this "if the socks
 version is set, we've parsed this much, ..." business.
   * The function should dispatch first on state, next on anything else.
   * We should think of a much better interface; the functions that call
 parse_socks have grown way too tricky.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3569>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online