[tor-bugs] #1926 [Tor Relay]: Extra-info descriptors have corrupt {write, read}-history lines

[Tor Bug Tracker & Wiki]

#1926: Extra-info descriptors have corrupt {write,read}-history lines
-----------------------+----------------------------------------------------
 Reporter:  karsten    |       Owner:  karsten           
     Type:  defect     |      Status:  new               
 Priority:  minor      |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Relay  |     Version:                    
 Keywords:             |      Points:                    
   Parent:             |  
-----------------------+----------------------------------------------------

Comment(by karsten):

 Replying to [comment:11 qbi]:
 > I have some suspicion that (part of) the bug is located in
 [https://gitweb.torproject.org/tor.git/blob/HEAD:/src/or/rephist.c#l1259
 rephist.c:1259]. If the date on a local computer is set to some point in
 the future, then AFAIS it returns this date. This happens until the real
 date is reached.

 I'm not sure which date you mean and how we would end up in the situation
 you describe.  Can you elaborate?

 But I wonder if we can assume that there is no big time difference between
 starting Tor and calling add_obs().  Except if you mean that single clock
 jumps while running Tor lead to this bug.  So, when starting Tor we should
 notice if our current system time differs much from the time stored in our
 state file.  I wonder if Tor writes apparently wrong timestamps to its
 state and doesn't validate these timestamps when loading the state.

 > Furthermore we should check if the value of `b `is really `NULL`. If not
 this should also give some nasty effects. I'll look into that later and
 comment some more.:)

 Which line?  Do you mean `NULL` or not `NULL`?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1926#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online