[tor-bugs] #2412 [Torctl]: TorCtl isn't joining on _thread

Wed Jan 19 17:19:42 UTC 2011

#2412: TorCtl isn't joining on _thread
--------------------+-------------------------------------------------------
 Reporter:  atagar  |       Owner:  mikeperry
     Type:  defect  |      Status:  new      
 Priority:  minor   |   Milestone:           
Component:  Torctl  |     Version:           
 Keywords:          |      Parent:           
--------------------+-------------------------------------------------------
 Very simple bug: the launch_thread function of torctl spawns two threads
 (self._thread and self._eventThread), but its close function only joins on
 self._eventThread [1]. The result is that the _thread lives a little
 longer (you can confirm this by checking threading.enumerate() after
 calling close):
 1/19/2011 09:18:49 [INFO] [<_MainThread(MainThread, started -1216911680)>,
 <Thread(TorLoop, started daemon -1217868944)>]

 This should be a trivial fix, though unfortunately it isn't the cause of
 the concurrency troubles I'm trying to track down. :(

 -Damian

 [1] https://gitweb.torproject.org/pytorctl.git/blob/HEAD:/TorCtl.py#l636

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2412>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online