[tor-bugs] #2332 [Tor Relay]: dnsserv_resolved has needless casts, unused strndup.

[Tor Bug Tracker & Wiki]

#2332: dnsserv_resolved has needless casts, unused strndup.
-----------------------+----------------------------------------------------
 Reporter:  rransom    |       Owner:  nickm             
     Type:  defect     |      Status:  assigned          
 Priority:  major      |   Milestone:  Tor: 0.2.1.x-final
Component:  Tor Relay  |     Version:                    
 Keywords:  easy       |      Parent:                    
-----------------------+----------------------------------------------------

Comment(by nickm):

 {{{
 Ok it's a truncated bit. What has buf around first 512 bytes, just
 curious?
 }}}

 I don't understand the question.

 {{{
 Why
 answer_len < 256
 missed for answer_type == RESOLVED_TYPE_HOSTNAME.
 }}}

 In dnsserv_resolv?  I've just added a check there.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2332#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online