[tor-bugs] #2317 [Tor Client]: Missing sanity checks for cbtnummodes consensus parameter

[Tor Bug Tracker & Wiki]

#2317: Missing sanity checks for cbtnummodes consensus parameter
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |       Owner:                    
     Type:  defect      |      Status:  needs_review      
 Priority:  major       |   Milestone:  Tor: 0.2.1.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 Reviewing:
   * All of our platforms are two's complement, so INT32_MAX is indeed
 always the same as (1<<31)-1 .
   * The non-constant minimum/maxiumum valuse in
 circuit_build_times_close_quantile() and
 circuit_build_times_initial_timeout() and networkstatus_get_bw_weight()
 make me a little twitchy.  Can those become constants, or get their checks
 moved out of the networkstatus_get_param() arguments?  My reasoning is
 that anything that makes networkstatus_get_param() have to clip a value is
 probably something to warn about loudly, but if the range is ever non-
 constant, we can't really have the warnings mean "something has gone wrong
 with your consensus".

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2317#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online