[tor-bugs] #2616 [Tor Client]: inconsistency in routerlist_add_family()
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Tue Feb 22 23:09:17 UTC 2011
#2616: inconsistency in routerlist_add_family()
------------------------+---------------------------------------------------
Reporter: arma | Owner:
Type: defect | Status: new
Priority: minor | Milestone: Tor: 0.2.3.x-final
Component: Tor Client | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
routerlist_add_family() is supposed to put the family members of "router"
into "sl". There are three rules: 1) If they're in the same /16 network
space. 2) If the descriptors declare they're in the same family. 3) If the
user's !NodeFamilies torrc option lists the router in a family.
In cases 1 and 2, they avoid listing "router" in the returned smartlist.
Case 3 though happily includes it.
This typically means that the caller of routerlist_add_family() ends up
with a smartlist with "router" in it twice, since most callers of the
function start by adding router to the smartlist first. My patch to #2403
is the first time we do it differently. I think it's safe in that
particular case. But we should still make the behavior consistent.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2616>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list