[tor-bugs] #1035 [Tor Relay]: Relay on dynamic IP marked as stable and guard

[Tor Bug Tracker & Wiki]

#1035: Relay on dynamic IP marked as stable and guard
------------------------------+---------------------------------------------
        Reporter:  rudis      |        Owner:  Sebastian         
            Type:  defect     |       Status:  needs_review      
        Priority:  minor      |    Milestone:  Tor: 0.2.2.x-final
       Component:  Tor Relay  |      Version:  0.2.0.35          
      Resolution:  None       |     Keywords:                    
          Parent:             |       Points:                    
Actualpointsdone:             |   Pointsdone:                    
    Actualpoints:             |  
------------------------------+---------------------------------------------

Comment(by arma):

 sebastian's 9b64227ffd38e would appear to have added an assert
 possibility,
 where if the function gets called with at_port != 0, but at_addr 0, then
 {{{
 +  } else if (addr_changed || port_changed) {
 }}}
 will be true, but then
 {{{
     tor_assert(at_addr);
 }}}

 I don't think we call it that way, currently, but still worth fixing.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1035#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online