[tor-bugs] #3825 [Tor Hidden Services]: HS intro points overloaded with CREATE cells cause connectivity failures

[Tor Bug Tracker & Wiki]

#3825: HS intro points overloaded with CREATE cells cause connectivity failures
---------------------------------+------------------------------------------
 Reporter:  atoruser             |          Owner:  rransom           
     Type:  defect               |         Status:  needs_review      
 Priority:  major                |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Hidden Services  |        Version:  Tor: unspecified  
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by rransom):

 Replying to [comment:20 nickm]:
 > re bug3825b-v8 :
 >
 > The only documented error I can find that you can get from time() is
 EFAULT, which shouldn't be possible for time(NULL).

 Fixup pushed.

 > Never float; always double.

 Fixup pushed.

 > In a (Double / int) calculation, you shouldn't need to cast the int to
 double; see the C standard, or K&R, or wherever.

 Fixup pushed.

 > The fractional_n_intro_points_wanted_to_replace_this_one calculation is
 tricky, and the extra parens for the casts make it harder to read.  It
 really needs a comment to explain what it's supposed to be calculating and
 why

 Multiple fixups pushed for this one.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3825#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online