[tor-bugs] #4722 [TorBrowserButton]: Rearranging tabs broken with Torbutton 1.4.5 on Windows

[Tor Bug Tracker & Wiki]

#4722: Rearranging tabs broken with Torbutton 1.4.5 on Windows
------------------------------+---------------------------------------------
 Reporter:  cypherpunks       |          Owner:  mikeperry
     Type:  defect            |         Status:  assigned 
 Priority:  major             |      Milestone:           
Component:  TorBrowserButton  |        Version:           
 Keywords:                    |         Parent:           
   Points:                    |   Actualpoints:           
------------------------------+---------------------------------------------
Changes (by mikeperry):

  * priority:  normal => major
  * status:  needs_information => assigned


Comment:

 This is probably a major issue (I know it annoyed the shit out of me on
 Linux until I fixed it there in 1.4.5), but the Windows side likely won't
 get fixed until early next year as I lack  Windows installations, Ubuntu
 Installations, and time. :/

 The problem lies in the invokeDragSessionWithImage override in components
 /external-app-blocker.js (see
 https://gitweb.torproject.org/torbutton.git/blob/master:/src/components
 /external-app-blocker.js#l227).

 Most likely, one of the "flavors" we block there is probably needed by
 Firefox for internal DnD on Windows. So long as it is not a flavor that
 Ubuntu sniffs (#4517), we can allow it.

 The other possibility is that we shouldn't set aActionType = 0 at the top
 of the function. It could be disabling internal drag-n-drops. Maybe the
 Firefox Windows code listens to it but we do not.

 The good news is that if you know even the slightest bit about how to
 unzip a file, edit a file, rezip and install it using a file:// url, it
 should be a pretty easy thing to try out these possibilities without much
 other than guess-and-check.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4722#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online