[tor-bugs] #4662 [Tor Relay]: Revert changes from bug4312 and thereafter until 0.2.4.x

[Tor Bug Tracker & Wiki]

#4662: Revert changes from bug4312 and thereafter until 0.2.4.x
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by asn):

 This is probably the wrong ticket to mention this, but
 `bug4626_callback_conditions_theory` (aka `b6c18f81f71`) should not be
 considered The Commit That Fixes Everything, if we want an -alpha any time
 soon.

 There are still bugs lurking in the code, like for example:
 {{{
 <wanoskarnet> ugh. ssl3_read_bytes(). seems like if SSL_ST_OK after
 calling handshake then it going to get record. if any one record there
 then it returns number of bytes n
 ot a error. most times it's impossible because non-blocking io, but non
 impossible. SSL_read() can return non error if reneg for some extremal
 cases.
 }}}

 I'm just mentioning this here, because I see Roger still considering
 `b6c18f81f71`.

 Roger, how did `revert_4312` work out for moria1?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4662#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online