[tor-bugs] #3803 [Tor Client]: connection_buckets_decrement() does lots of stuff that bufferevents need to do someplace

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Mon Aug 29 17:22:23 UTC 2011


#3803: connection_buckets_decrement() does lots of stuff that bufferevents need to
do someplace
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:  nickm             
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:  #3561             
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by Sebastian):

 changelog typo: "we're" -> "we've"

 Otherwise, looks ok. One question: Inside record_num_bytes_transferred(),
 we don't bail out anymore if num_read or num_written is larger than
 INT_MAX. I took a quick look at the rephist code, and that seemed ok.
 Still, was that change intentional?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3803#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list