[tor-bugs] #3335 [Tor Hidden Services]: Remove an HS's entries in last_hid_serv_requests when a connection attempt ends

[Tor Bug Tracker & Wiki]

#3335: Remove an HS's entries in last_hid_serv_requests when a connection attempt
ends
---------------------------------+------------------------------------------
 Reporter:  rransom              |          Owner:  rransom           
     Type:  enhancement          |         Status:  new               
 Priority:  normal               |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by rransom):

 The easiest way to notice that a hidden service connection attempt has
 ended is to notice that:
  * a stream trying to connect to an HS has timed out without being
 attached to a circuit,
  * a stream trying to connect to an HS has been attached successfully, or
  * all streams trying to connect to an HS are being closed because Tor has
 tried an HS descriptor from each directory and still failed to open a
 rendezvous circuit.

 There may be other cases that we should consider to 'end' an HS connection
 attempt.  This fix should be safe enough to backport to 0.2.2.x after it
 has been tested on 0.2.3.x a bit.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3335#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online