[tor-bugs] #3683 [Tor Client]: Stream-isolation code does not handle NULs in SOCKS auth fields properly

[Tor Bug Tracker & Wiki]

#3683: Stream-isolation code does not handle NULs in SOCKS auth fields properly
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:  nickm             
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by rransom):

 Replying to [comment:4 nickm]:
 > Okay, I think I fixed all of the above in branch bug3683 in my public
 repo.

 Looks good!

 > (Except for asserting that socks_request is set.  The rule, as far as I
 can figure, is that socks_request must be set for every CONN_TYPE_AP
 stream.  Once I merge the patch that makes entry_connection_t exist, we
 can make the checks more unified, or just inline it.)

 OK.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3683#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online