[tor-bugs] #2704 [Tor Relay]: BandwidthObserved higher than BandwidthBurst

[Tor Bug Tracker & Wiki]

#2704: BandwidthObserved higher than BandwidthBurst
--------------------------+-------------------------------------------------
    Reporter:  keb        |       Owner:  Sebastian                        
        Type:  defect     |      Status:  reopened                         
    Priority:  major      |   Milestone:  Tor: 0.2.2.x-final               
   Component:  Tor Relay  |     Version:  Tor: 0.2.2.23-alpha              
  Resolution:             |    Keywords:  0.2.2.23-alpha bandwidth observed
      Parent:             |      Points:                                   
Actualpoints:             |  
--------------------------+-------------------------------------------------

Comment(by Sebastian):

 Here's another bug in rep_hist_update_bwhist_state_section(), I think:
 {{{
   tor_asprintf(&cp, U64_FORMAT, U64_PRINTF_ARG(b->max_total & ~0x3ff));
   smartlist_add(*s_maxima, cp);
 }}
 It seems we need to divide b->max_total by NUM_SECS_ROLLING_MEASURE, no?

 Also, this following change from 105b94b7 seems to be strange to me, but I
 can't put my finger on why so far.
 {{{
    /* Clean up maxima and observed */
 -  /* Do we really want to zero this for the purpose of max capacity? */
    for (i=0; i<NUM_SECS_ROLLING_MEASURE; ++i) {
      b->obs[i] = 0;
    }
    b->total_obs = 0;
 -  for (i=0; i<NUM_TOTALS; ++i) {
 -    b->maxima[i] = 0;
 -  }
 -  b->max_total = 0;
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2704#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online