[tor-bugs] #2800 [Tor Client]: Resolve or postpone all XXX022/XXX021 items

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Wed Apr 6 23:02:28 UTC 2011


#2800: Resolve or postpone all XXX022/XXX021 items
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 {{{
 -        expired = ftime_definitely_after(now, cert->expires);
 +        expired = now > cert->expires;

 ...

 -      if (!ftime_definitely_after(now, cert->expires)) {
 +      if (now < cert->expires) {
 }}}

 This replacement doesn't produce exactly the same functionality. I'm not
 sure if we care.

 For example, might the second one want to be "<="?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2800#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list