[tor-bugs] #2559 [Tor Relay]: connection buckets get not decremented in a private tor network

[Tor Bug Tracker & Wiki]

#2559: connection buckets get not decremented in a private tor network
----------------------------+-----------------------------------------------
    Reporter:  cagara       |       Owner:  cagara            
        Type:  enhancement  |      Status:  reopened          
    Priority:  normal       |   Milestone:  Tor: 0.2.3.x-final
   Component:  Tor Relay    |     Version:                    
  Resolution:               |    Keywords:                    
      Parent:               |      Points:                    
Actualpoints:               |  
----------------------------+-----------------------------------------------

Comment(by arma):

 I hate boolean logic, but isn't the logic here backwards?

 {{{
 If it's linked, return 0: not rate limited

 If it's localhost && CountPrivateBandwidth, return 0: not rate limited

 If it's localhost && !CountPrivateBandwidth, return 1, rate limited
 }}}

 Line 2 and Line 3 are the reverse of what they ought to be.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2559#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online