[tor-bugs] #2030 [Tor Relay]: Make tor_check_port_forwarding more generic

[Tor Bug Tracker & Wiki]

#2030: Make tor_check_port_forwarding more generic
-----------------------+----------------------------------------------------
 Reporter:  sjmurdoch  |       Owner:  sjmurdoch
     Type:  defect     |      Status:  new      
 Priority:  minor      |   Milestone:           
Component:  Tor Relay  |     Version:           
 Keywords:             |      Parent:  #1775    
-----------------------+----------------------------------------------------
 tor_check_port_forwarding() in util.c contains both code specific to tor-
 fw-helper as well as generic code for launching a child process. It might
 be useful to make this more generic so it could be used for launching
 other processes.

 On this topic, in bug #1903, nickm said:

 > It seems that the code here does two things: one is a general task
 "Launch a
 > child process and see what it says" and another is a more specific task
 > "Launch a tor-fw-helper instance and act based on its output.)" It might
 be a
 > good idea to disentangle these eventually, in case we ever want to
 launch
 > anything else.
 >
 > It might be cleaner to move the static variables from
 > tor_check_port_forwarding into some kind of struct, in case we ever want
 to
 > launch two things in the future.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2030>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online