[tor-bugs] #2205 [Tor Relay]: private network of nodes running master doesn't allow client requests to complete

[Tor Bug Tracker & Wiki]

#2205: private network of nodes running master doesn't allow client requests to
complete
-----------------------+----------------------------------------------------
 Reporter:  Sebastian  |       Owner:                    
     Type:  defect     |      Status:  new               
 Priority:  major      |   Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |     Version:                    
 Keywords:             |      Parent:                    
-----------------------+----------------------------------------------------

Comment(by cypherpunks):

 Wrong patch.
 {{{
 -      if (tls->negotiated_callback)
 +      if (tls->negotiated_callback) {
 +        log_notice(LD_HANDSHAKE, "Calling renegotiated_callback while in
 "
 +                   "state %d [%s]", tls->ssl->state,
 +                   ssl_state_to_string(tls->ssl->state));
          tls->negotiated_callback(tls, tls->callback_arg);
 +      }
 }}}

 tor_tls_read()?

 {{{
   r = SSL_read(tls->ssl, cp, (int)len);
   if (r > 0) {
 }}}
 Of course, such log_notice happen after success handshake only.

 But!

 Problem is connection_or_tls_renegotiated_cb() while it happen inside
 connection_or_process_inbuf(), for any non fatal result of SSL_read()
 while it does handshake.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2205#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online