[tor-bugs] #2210 [Tor Relay]: Stream starvation due to activation order in circuit_resume_edge_reading_helper()

[Tor Bug Tracker & Wiki]

#2210: Stream starvation due to activation order in
circuit_resume_edge_reading_helper()
-----------------------+----------------------------------------------------
 Reporter:  nickm      |       Owner:  nickm             
     Type:  defect     |      Status:  needs_review      
 Priority:  normal     |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Relay  |     Version:                    
 Keywords:  fairness   |      Parent:  #1298             
-----------------------+----------------------------------------------------

Comment(by iang):

 We used random() because we didn't want to drain cryptographic entropy for
 this, since it's not necessary.

 We appear to be using libevent 1.3b.

 nickm, you have the conch, but I think picking a random index isn't as
 nice, since you'll then have to iterate through the list to find the ith
 item anyway.  If you're already iterating through the list earlier,
 perhaps put the "select a random list item" code in that loop?

 I totally agree on the duplicated code, and on the n_streams /
 num_streams.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2210#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online