[tor-bugs] #1692 [Tor Relay]: No Events for SETCONF

[Tor Bug Tracker & Wiki]

#1692: No Events for SETCONF
-------------------------+--------------------------------------------------
 Reporter:  atagar       |       Owner:  atagar          
     Type:  enhancement  |      Status:  assigned        
 Priority:  normal       |   Milestone:  Tor: unspecified
Component:  Tor Relay    |     Version:  Tor: unspecified
 Keywords:               |      Parent:                  
-------------------------+--------------------------------------------------
Changes (by atagar):

  * status:  needs_review => assigned
  * milestone:  Tor: 0.2.3.x-final => Tor: unspecified


Comment:

 This change is incomplete. Sebastian has pointed out that there's still a
 memory leak with one of the attributes and the missing changes file (both
 easy to fix). However, there's a bigger problem in that the formatting for
 multiline messages isn't right. This is tersely defined in section 2.3 of
 the control-spec and an example for handling it can be found in the
 handle_control_getinfo function of 'control.c'. That said, this is looking
 like a bigger headache and timesink that I'm willing to put into it at
 this point so I'm mothballing this for now. Putting the milestone back to
 unspecified.

 Here's the relevant irc discussion snippets in case someone else wants to
 pick it up:
 19:59 < special> see section 2.3,
 MidReplyLine/DataReplyLineandEndReplyLine
 20:06 < special> atagar: response lines are in the form of code[ -+]
 depending on if there are more lines in the response
 20:07 < special> - is mid, + is data, space is end
 20:07 < special> so you can do "250+XXX\r\n250 YYY"
 20:10 < rransom> special: That example is incomplete -- you need a
 "\r\n.\r\n" after it, and the ‘Data’ would then contain the text "250
 YYY".
 20:11 < special> rransom: where is the '.' defined?
 20:12 < special> oh, nevermind
 20:13 < atagar> Then guess I'm the only one a little lost. What is the
 period for?
 20:13 < special> atagar: it's like SMTP
 20:13 < katmagic> The period is to terminate the data.
 20:13 < special> 'data' is terminated by the \r\n.\r\n

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1692#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online